기여 목록 / 8450591
[DevTools] Remove blank-origins-not-shown test after crrev.com/c/8450050
DevToolstestMerged
CL 8450050에서 unit test로 옮긴 기존 blank-origins-not-shown 웹 테스트를 제거했습니다.
문제 설명
unit test로 옮긴 뒤에도 기존 Chromium 웹 테스트가 남아 있었습니다.
해결 내용
blank-origins-not-shown.js와 blank-origins-not-shown-expected.txt를 제거했습니다.
전체 코드 diff는 다음과 같습니다.
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
deleted file mode 100644
index 23e486c..0000000
--- a/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-Tests that blank origins aren't shown in the security panel origins list.
-
-Group: Main origin
-Group: Unknown / canceled
-<SPAN class=highlighted-url >
- <SPAN class=url-scheme-unknown >
-https
- </SPAN>
- <SPAN class=url-scheme-separator >
-://
- </SPAN>
- <SPAN >
-foo.test
- </SPAN>
-</SPAN>
-<SPAN class=url-scheme-unknown >
-https
-</SPAN>
-<SPAN class=url-scheme-separator >
-://
-</SPAN>
-<SPAN >
-foo.test
-</SPAN>
-
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown.js b/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown.js
deleted file mode 100644
index 5303fce2..0000000
--- a/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown.js
+++ /dev/null
@@ -1,27 +0,0 @@
-// Copyright 2017 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import {TestRunner} from 'test_runner';
-import {SecurityTestRunner} from 'security_test_runner';
-
-import * as SDK from 'devtools/core/sdk/sdk.js';
-
-(async function() {
- TestRunner.addResult(`Tests that blank origins aren't shown in the security panel origins list.\n`);
- await TestRunner.showPanel('security');
-
- var request1 = SDK.NetworkRequest.NetworkRequest.create(
- 0, 'https://foo.test/foo.jpg', 'https://foo.test', 0, 0, null);
- SecurityTestRunner.dispatchRequestFinished(request1);
-
- var request2 = SDK.NetworkRequest.NetworkRequest.create(
- 0,
- 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAkAAAAKCAYAAABmBXS+AAAAPElEQVR42mNgQAMZGRn/GfABkIIdO3b8x6kQpgAEsCpEVgADKAqxKcBQCCLwARRFIBodYygiyiSCighhAO4e2jskhrm3AAAAAElFTkSuQmCC',
- 'https://foo.test', 0, 0, null);
- SecurityTestRunner.dispatchRequestFinished(request2);
-
- SecurityTestRunner.dumpSecurityPanelSidebarOrigins();
-
- TestRunner.completeTest();
-})();테스트 방법
최종 patchset의 CQ 실행이 통과했습니다.
배운 점
테스트 migration 후에는 기존 테스트와 기대 결과 파일도 함께 정리해야 합니다.