기여 목록 / 8399066
[DevTools] Rebaseline and re-enable tests after crrev.com/c/8289248
DevToolstestMerged
보안 웹 테스트 4개의 기대 결과를 갱신하고 임시 설정을 제거했습니다.
문제 설명
CL 8289248 반영 후, 변경된 DOM 출력에 맞춰 기대 결과를 갱신해야 했습니다.
해결 내용
테스트 4개의 -expected.txt에 Lit 주석 노드와 버튼 속성 변경을 반영하고,
TestExpectations에서 관련 [ Failure Pass ] 항목과 주석을 제거했습니다.
전체 코드 diff는 다음과 같습니다.
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index b47de3d0..038fcef0 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -4163,12 +4163,6 @@
crbug.com/535451658 http/tests/devtools/console-xhr-logging-async.js [ Failure Pass ]
crbug.com/535451658 http/tests/devtools/console-xhr-logging.js [ Failure Pass ]
-## Disable layout tests to land crrev.com/c/8289248
-crbug.com/407750721 http/tests/devtools/security/origin-view-ct-compliance.js [ Failure Pass ]
-crbug.com/407750721 http/tests/devtools/security/origin-view-noncryptographic-secure-origin.js [ Failure Pass ]
-crbug.com/407750721 http/tests/devtools/security/origin-view-then-interstitial.js [ Failure Pass ]
-crbug.com/407750721 http/tests/devtools/security/security-details-updated-with-security-state.js [ Failure Pass ]
-
# See also crbug.com/920100 (sheriff 2019-01-09).
crbug.com/626703 external/wpt/referrer-policy/css-integration/svg/external-stylesheet.html [ Failure Timeout ]
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
index e399e52..d585f34 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
@@ -7,14 +7,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -42,11 +42,11 @@
foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -57,7 +57,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt
index c8dc2208..cd8bf01 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt
@@ -7,14 +7,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -42,11 +42,11 @@
test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -57,7 +57,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
index bfc1645..9df54c2 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
@@ -57,14 +57,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=warning class=security-property security-property-insecure >
<#document-fragment >
<STYLE >
@@ -92,11 +92,11 @@
foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -107,7 +107,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
index 1a5dc80..b486678 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
@@ -171,14 +171,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -206,11 +206,11 @@
foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -221,7 +221,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
@@ -411,14 +411,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -446,11 +446,11 @@
ecdhe.foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -461,7 +461,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
@@ -658,14 +658,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -693,11 +693,11 @@
tls13.foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -708,7 +708,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >
@@ -905,14 +905,14 @@
<STYLE >
</STYLE>
<DIV class=title-section >
+ <#comment >
+ </#comment>
<DIV class=title-section-header role=heading aria-level=1 >
+ <#comment >
+ </#comment>
Origin
</DIV>
<DIV class=origin-display >
- <#comment >
- </#comment>
- <#comment >
- </#comment>
<DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
<#document-fragment >
<STYLE >
@@ -940,11 +940,11 @@
ech.foo.test
</SPAN>
</SPAN>
- <#comment >
- </#comment>
</DIV>
<DIV class=view-network-button >
- <DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
+ <DEVTOOLS-BUTTON role=presentation >
+ <#comment >
+ </#comment>
View requests in Network panel
<#document-fragment >
<#comment >
@@ -955,7 +955,7 @@
<#comment >
</#comment>
</STYLE>
- <BUTTON class=outlined >
+ <BUTTON class= outlined jslog=Action; track: click; context: reveal-in-network >
<#comment >
</#comment>
<#comment >테스트 방법
Gerrit에 기록된 CQ 실행은 통과했으며, 2026년 9월 12일(한국 시간) Chromium main에 병합되었습니다.
배운 점
기대 결과 갱신과 함께 임시 설정을 제거해야 이후 예상 밖의 실패를 다시 검출할 수 있습니다.