기여 목록 / 8311089
[DevTools] Rebaseline and re-enable tests after crrev.com/c/8303474
DevToolstestMerged
보안 웹 테스트 2개의 기대 결과를 갱신하고 임시 설정을 제거했습니다.
문제 설명
CL 8303474 반영 후, 변경된 DOM 출력에 맞춰 기대 결과를 갱신해야 했습니다.
해결 내용
테스트 2개의 -expected.txt에 Lit 주석 노드와 connection-section 클래스
추가를 반영하고, TestExpectations에서 관련 [ Failure Pass ] 항목과 주석을
제거했습니다.
전체 코드 diff는 다음과 같습니다.
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index 52b09d7..883a9e1 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -4197,10 +4197,6 @@
crbug.com/535451658 http/tests/devtools/console-xhr-logging-async.js [ Failure Pass ]
crbug.com/535451658 http/tests/devtools/console-xhr-logging.js [ Failure Pass ]
-## Disable layout tests to land crrev.com/c/8303474
-crbug.com/407750721 http/tests/devtools/security/origin-view-ct-compliance.js [ Failure Pass ]
-crbug.com/407750721 http/tests/devtools/security/security-details-updated-with-security-state.js [ Failure Pass ]
-
# See also crbug.com/920100 (sheriff 2019-01-09).
crbug.com/626703 external/wpt/referrer-policy/css-integration/svg/external-stylesheet.html [ Failure Timeout ]
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
index 9c33378..e399e52 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
@@ -71,36 +71,70 @@
</DEVTOOLS-BUTTON>
</DIV>
</DIV>
- <DIV class=origin-view-section >
+ <DIV class=origin-view-section connection-section >
+ <#comment >
+ </#comment>
<DIV class=origin-view-section-title role=heading aria-level=2 >
+ <#comment >
+ </#comment>
Connection
</DIV>
+ <#comment >
+ </#comment>
<TABLE class=details-table >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Protocol
</TD>
<TD >
+ <#comment >
+ </#comment>
TLS 1.2
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Key exchange
</TD>
<TD >
+ <#comment >
+ </#comment>
Key_Exchange
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Cipher
</TD>
<TD >
+ <#comment >
+ </#comment>
Cypher with Mac
</TD>
</TR>
+ <#comment >
+ </#comment>
</TABLE>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title role=heading aria-level=2 >
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
index 523a88a..1a5dc80 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
@@ -235,36 +235,70 @@
</DEVTOOLS-BUTTON>
</DIV>
</DIV>
- <DIV class=origin-view-section >
+ <DIV class=origin-view-section connection-section >
+ <#comment >
+ </#comment>
<DIV class=origin-view-section-title role=heading aria-level=2 >
+ <#comment >
+ </#comment>
Connection
</DIV>
+ <#comment >
+ </#comment>
<TABLE class=details-table >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Protocol
</TD>
<TD >
+ <#comment >
+ </#comment>
TLS 1.2
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Key exchange
</TD>
<TD >
+ <#comment >
+ </#comment>
Key_Exchange
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Cipher
</TD>
<TD >
+ <#comment >
+ </#comment>
Cypher with Mac
</TD>
</TR>
+ <#comment >
+ </#comment>
</TABLE>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title role=heading aria-level=2 >
@@ -441,44 +475,86 @@
</DEVTOOLS-BUTTON>
</DIV>
</DIV>
- <DIV class=origin-view-section >
+ <DIV class=origin-view-section connection-section >
+ <#comment >
+ </#comment>
<DIV class=origin-view-section-title role=heading aria-level=2 >
+ <#comment >
+ </#comment>
Connection
</DIV>
+ <#comment >
+ </#comment>
<TABLE class=details-table >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Protocol
</TD>
<TD >
+ <#comment >
+ </#comment>
TLS 1.2
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Key exchange
</TD>
<TD >
+ <#comment >
+ </#comment>
ECDSA_RSA with X25519
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Server signature
</TD>
<TD >
+ <#comment >
+ </#comment>
RSA-PSS with SHA-256
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Cipher
</TD>
<TD >
+ <#comment >
+ </#comment>
AES-128-GCM
</TD>
</TR>
+ <#comment >
+ </#comment>
</TABLE>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title role=heading aria-level=2 >
@@ -646,44 +722,86 @@
</DEVTOOLS-BUTTON>
</DIV>
</DIV>
- <DIV class=origin-view-section >
+ <DIV class=origin-view-section connection-section >
+ <#comment >
+ </#comment>
<DIV class=origin-view-section-title role=heading aria-level=2 >
+ <#comment >
+ </#comment>
Connection
</DIV>
+ <#comment >
+ </#comment>
<TABLE class=details-table >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Protocol
</TD>
<TD >
+ <#comment >
+ </#comment>
TLS 1.3
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Key exchange
</TD>
<TD >
+ <#comment >
+ </#comment>
X25519
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Server signature
</TD>
<TD >
+ <#comment >
+ </#comment>
RSA-PSS with SHA-256
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Cipher
</TD>
<TD >
+ <#comment >
+ </#comment>
AES-128-GCM
</TD>
</TR>
+ <#comment >
+ </#comment>
</TABLE>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title role=heading aria-level=2 >
@@ -851,52 +969,102 @@
</DEVTOOLS-BUTTON>
</DIV>
</DIV>
- <DIV class=origin-view-section >
+ <DIV class=origin-view-section connection-section >
+ <#comment >
+ </#comment>
<DIV class=origin-view-section-title role=heading aria-level=2 >
+ <#comment >
+ </#comment>
Connection
</DIV>
+ <#comment >
+ </#comment>
<TABLE class=details-table >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Protocol
</TD>
<TD >
+ <#comment >
+ </#comment>
TLS 1.3
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Key exchange
</TD>
<TD >
+ <#comment >
+ </#comment>
X25519
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Server signature
</TD>
<TD >
+ <#comment >
+ </#comment>
RSA-PSS with SHA-256
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Cipher
</TD>
<TD >
+ <#comment >
+ </#comment>
AES-128-GCM
</TD>
</TR>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
<TR class=details-table-row >
<TD >
+ <#comment >
+ </#comment>
Encrypted ClientHello
</TD>
<TD >
+ <#comment >
+ </#comment>
enabled
</TD>
</TR>
+ <#comment >
+ </#comment>
</TABLE>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=origin-view-section >
<DIV class=origin-view-section-title role=heading aria-level=2 >테스트 방법
Gerrit에 기록된 CQ 실행은 통과했으며, 2026년 9월 10일(한국 시간) Chromium main에 병합되었습니다.
배운 점
DOM 출력 기반 테스트는 Lit 주석 노드 추가에도 기대 결과 갱신이 필요합니다. 리뷰에서는 해당 테스트를 DevTools 쪽 E2E 테스트로 옮기자는 제안을 받았습니다.