기여 목록 / 8140384
[DevTools] Re-baseline and re-enable security web tests after crrev.com/c/8045801
DevToolstestMerged
SAN Lit 전환을 반영하기 위해 테스트 기대값을 임시 조정한 CL 8096246의 후속 작업입니다. 보안 웹 테스트 2개의 기대 결과를 갱신하고, 성공과 실패를 모두 허용하던 임시 설정을 제거했습니다.
문제 설명
CL 8096246에서는 SAN Lit 전환을 위해 보안 웹 테스트 2개의 기대값을 임시로 조정했습니다. DevTools 변경이 Chromium에 반영된 뒤에는 새 DOM 출력에 맞게 기대 결과를 갱신하고, 정상적인 검증 기준으로 되돌려야 했습니다.
해결 내용
origin-view-ct-compliance-expected.txt와security-details-updated-with-security-state-expected.txt에 SAN 표시의 DOM 변경을 반영했습니다. Lit이 추가한 주석 노드, SAN 목록을 감싸는 요소와 클래스 속성 출력의 변경을 포함합니다.TestExpectations에서 관련[ Failure Pass ]항목 2개와 주석을 제거했습니다.
전체 코드 diff는 다음과 같습니다.
diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index 33ade5d..093b006a 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -68,10 +68,6 @@
crbug.com/457388389 http/tests/devtools/sources/debugger-pause/set-return-value.js [ Failure Pass Timeout ]
-# Disable layout tests to land crrev.com/c/8045801
-http/tests/devtools/security/origin-view-ct-compliance.js [ Failure Pass ]
-http/tests/devtools/security/security-details-updated-with-security-state.js [ Failure Pass ]
-
# Disabled to land https://crrev.com/c/8117529
crbug.com/407751377 http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js [ Failure Pass Timeout ]
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
index 75dcc68..9c33378 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
@@ -121,12 +121,32 @@
</TD>
<TD >
<DIV >
- <SPAN class=san-entry >
+ <#comment >
+ </#comment>
+ <DIV class= san >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
foo.test
- </SPAN>
- <SPAN class=san-entry >
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
*.test
- </SPAN>
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ </DIV>
</DIV>
</TD>
</TR>
diff --git a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
index daaa8281..523a88a 100644
--- a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
@@ -285,12 +285,32 @@
</TD>
<TD >
<DIV >
- <SPAN class=san-entry >
+ <#comment >
+ </#comment>
+ <DIV class= san >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
foo.test
- </SPAN>
- <SPAN class=san-entry >
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
*.test
- </SPAN>
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ </DIV>
</DIV>
</TD>
</TR>
@@ -479,9 +499,23 @@
</TD>
<TD >
<DIV >
- <SPAN class=san-entry >
+ <#comment >
+ </#comment>
+ <DIV class= san >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
ecdhe.foo.test
- </SPAN>
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ </DIV>
</DIV>
</TD>
</TR>
@@ -670,9 +704,23 @@
</TD>
<TD >
<DIV >
- <SPAN class=san-entry >
+ <#comment >
+ </#comment>
+ <DIV class= san >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
tls13.foo.test
- </SPAN>
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ </DIV>
</DIV>
</TD>
</TR>
@@ -869,9 +917,23 @@
</TD>
<TD >
<DIV >
- <SPAN class=san-entry >
+ <#comment >
+ </#comment>
+ <DIV class= san >
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <SPAN class= san-entry >
+ <#comment >
+ </#comment>
ech.foo.test
- </SPAN>
+ </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ </DIV>
</DIV>
</TD>
</TR>테스트 방법
CL에 기록한 테스트는 다음과 같습니다.
third_party/blink/tools/run_web_tests.py http/tests/devtools/security/2026년 7월 24일 Chromium main에 병합되었습니다.
배운 점
- DOM을 출력하는 테스트는 화면에 보이는 내용이 같아도 요소 구조나 Lit 주석 노드가 달라지면 기대 결과를 갱신해야 합니다.
- 기대 결과 갱신과 함께 임시 설정을 제거해야 이후 예상 밖의 실패를 다시 검출할 수 있습니다.