기여 목록 / 8042189
Re-baseline and re-enable DevTools security layout tests after crrev.com/c/7969697
DevToolstestMerged
Origin Lit 전환 이후 보안 웹 테스트 8개의 기대 결과를 갱신하고, 성공과 실패를 모두 허용하던 임시 설정을 제거했습니다.
문제 설명
CL 8038580에서는 Origin Lit 전환을 위해 보안 웹 테스트 8개의 기대값을 임시로 조정했습니다. 변경이 Chromium에 반영된 뒤에는 새 DOM 출력에 맞게 기대 결과를 갱신하고, 정상적인 검증 기준으로 되돌려야 했습니다.
해결 내용
- 테스트 8개의
-expected.txt에 Lit 주석 노드와 아이콘 주변 요소 구조의 변경을 반영했습니다. - 작업 중 반영된 CL 8069249의 UI 문구 변경도 기대 결과에 포함했습니다.
예를 들어
Network Panel이Network panel로 바뀐 내용을 반영했습니다. TestExpectations에서 관련[ Failure Pass ]항목 8개와 주석을 제거했습니다.
전체 diff는 다음과 같습니다.
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt
@@ -61,31 +61,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=warning class=security-property security-property-insecure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-warning); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=warning class=security-property security-property-insecure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-warning); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-insecure >
+ <#comment >
+ </#comment>
http
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
@@ -114,7 +126,7 @@
Not secure
</DIV>
<DIV >
-Your connection to this origin is not secure.
+Your connection to this origin isn’t secure.
</DIV>
</DIV>
</DIV>
--- a/third_party/blink/web_tests/http/tests/devtools/security/security-unknown-resource-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/security-unknown-resource-expected.txt
@@ -4,22 +4,34 @@
Group: Unknown / canceled
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
http
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
unknown
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
http
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
unknown
</SPAN>
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-noncryptographic-secure-origin-expected.txt
@@ -11,31 +11,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
chrome-test
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -68,15 +68,6 @@
crbug.com/457388389 http/tests/devtools/sources/debugger-pause/set-return-value.js [ Failure Pass Timeout ]
-# Disable layout tests to land crrev.com/c/7969697
-http/tests/devtools/security/blank-origins-not-shown.js [ Failure Pass ]
-http/tests/devtools/security/failed-request.js [ Failure Pass ]
-http/tests/devtools/security/main-origin-assigned-despite-request-missing.js [ Failure Pass ]
-http/tests/devtools/security/origin-view-ct-compliance.js [ Failure Pass ]
-http/tests/devtools/security/origin-view-noncryptographic-secure-origin.js [ Failure Pass ]
-http/tests/devtools/security/origin-view-then-interstitial.js [ Failure Pass ]
-http/tests/devtools/security/security-details-updated-with-security-state.js [ Failure Pass ]
-http/tests/devtools/security/security-unknown-resource.js [ Failure Pass ]
# Reftest failure related to off-main-thread interaction (imperceptible AA differences)
crbug.com/395909730 virtual/off-main-thread-css-paint/http/tests/csspaint/paint2d-zoom.html [ Failure ] # Reftest image failure
crbug.com/395909730 virtual/off-main-thread-css-paint/http/tests/csspaint/transform-with-page-zoom-003.html [ Failure ] # Reftest image failure
--- a/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/blank-origins-not-shown-expected.txt
@@ -4,22 +4,34 @@
Group: Unknown / canceled
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
--- a/third_party/blink/web_tests/http/tests/devtools/security/failed-request-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/failed-request-expected.txt
@@ -4,43 +4,67 @@
Group: Secure origins
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
Group: Unknown / canceled
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
does-not-resolve.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
does-not-resolve.test
</SPAN>
--- a/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt
@@ -11,31 +11,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
@@ -182,7 +194,7 @@
<DIV class=sct-details hidden >
</DIV>
<DIV class=origin-view-section-notes >
-This request complies with Chrome's Certificate Transparency policy.
+This request complies with Chrome’s Certificate Transparency policy.
</DIV>
</DIV>
<DIV class=origin-view-section origin-view-notes >
--- a/third_party/blink/web_tests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/main-origin-assigned-despite-request-missing-expected.txt
@@ -5,63 +5,99 @@
Group: Main origin
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
http
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
127.0.0.1:8000
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
http
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
127.0.0.1:8000
</SPAN>
Group: Unknown / canceled
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
bar.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
bar.test
</SPAN>
--- a/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
+++ b/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt
@@ -5,103 +5,163 @@
Group: Secure origins
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ecdhe.foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ecdhe.foo.test
</SPAN>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
tls13.foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
tls13.foo.test
</SPAN>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ech.foo.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ech.foo.test
</SPAN>
Group: Unknown / canceled
<SPAN class=highlighted-url >
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
bar.test
</SPAN>
</SPAN>
<SPAN class=url-scheme-unknown >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
bar.test
</SPAN>
Origin view (https://foo.test) -----------------
@@ -115,31 +175,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
@@ -289,31 +361,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ecdhe.foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
@@ -468,31 +552,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
tls13.foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>
@@ -647,31 +743,43 @@
Origin
</DIV>
<DIV class=origin-display >
- <SPAN >
- <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
- <#document-fragment >
- <STYLE >
- </STYLE>
- <SPAN style=--icon-url: var(--image-file-lock); >
- </SPAN>
- </#document-fragment>
- </DEVTOOLS-ICON>
- </SPAN>
+ <#comment >
+ </#comment>
+ <#comment >
+ </#comment>
+ <DEVTOOLS-ICON role=presentation name=lock class=security-property security-property-secure >
+ <#document-fragment >
+ <STYLE >
+ </STYLE>
+ <SPAN style=--icon-url: var(--image-file-lock); >
+ </SPAN>
+ </#document-fragment>
+ </DEVTOOLS-ICON>
+ <#comment >
+ </#comment>
<SPAN class=highlighted-url >
<SPAN class=url-scheme-secure >
+ <#comment >
+ </#comment>
https
</SPAN>
<SPAN class=url-scheme-separator >
+ <#comment >
+ </#comment>
://
</SPAN>
<SPAN >
+ <#comment >
+ </#comment>
ech.foo.test
</SPAN>
</SPAN>
+ <#comment >
+ </#comment>
</DIV>
<DIV class=view-network-button >
<DEVTOOLS-BUTTON role=link jslog=Action; track: click; context: reveal-in-network >
-View requests in Network Panel
+View requests in Network panel
<#document-fragment >
<#comment >
</#comment>테스트 방법
CL에 기록한 테스트는 다음과 같습니다.
third_party/blink/tools/run_web_tests.py http/tests/devtools/security/리뷰 과정에서 추가 UI 문구 변경에 따른 tryjob 실패를 확인하고 기대 결과를 갱신했습니다. 최종적으로 CQ를 거쳐 2026년 7월 16일(한국 시간) Chromium main에 병합되었습니다.
배운 점
- 기대 결과를 갱신할 때는 DOM 구조뿐 아니라, 작업 중 반영된 UI 문구 변경도 함께 확인해야 합니다.
- 임시로 조정한 기대값을 제거해야 이후의 예상 밖의 실패를 다시 검출할 수 있습니다.